linux-kernel - Re: [PATCH blktests v3 04/12] common/xfs: Limit fio size job to fit into xfs fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2023 09:29:04 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Daniel Wagner <dwagner@...e.de>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <chaitanyak@...dia.com>,
        Shin'ichiro Kawasaki <shinichiro@...tmail.com>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH blktests v3 04/12] common/xfs: Limit fio size job to fit
 into xfs fs

On 5/3/23 01:02, Daniel Wagner wrote:
> The usable capacity of the filesystem is less than the raw
> partition/device size due to the additional meta/log data.
>
> Ensure that the job size for fio is not exceeding the limits.
>
> Because we have hard coded the path where we mount the filesystem
> and don't want to expose this, we just update max size inside
> _xfs_run_fio_verify_io(). No need to leak this into the caller.
>
> Signed-off-by: Daniel Wagner <dwagner@...e.de>
> ---
>   common/xfs | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/common/xfs b/common/xfs
> index 413c2820ffaf..37ce85878df2 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -37,6 +37,9 @@ _xfs_run_fio_verify_io() {
>   		sz_mb="${avail_mb}"
>   	else
>   		sz_mb="$(convert_to_mb "${sz}")"
> +		if [[ "${sz_mb}" -gt "${avail_mb}" ]]; then
> +			sz_mb="${avail_mb}"
> +		fi
>   	fi
>   
>   	_run_fio_verify_io --size="${sz_mb}m" --directory="${mount_dir}/"


this is exactly how it should to start with, the only
is now we are silently reducing the fio job size maybe that is okay ?

or we should error out here instead of being smart ?

-ck