linux-kernel - Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dIXozfBEyCqYQ9-l0IgxfaoL6paYc_6NjXMxHp3qUqAxQdF-c5qRoULMp4K_Lv4bCOPRez2c_4v4PuFKMysFxhNkK2r1t0grU89YosKzTbE=@proton.me>
Date:   Wed, 03 May 2023 10:45:06 +0000
From:   Benno Lossin <benno.lossin@...ton.me>
To:     materoy@...ton.me
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Alice Ryhl <aliceryhl@...gle.com>,
        Martin Rodriguez Reboredo <yakoyoku@...il.com>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's #includes

On 27.04.23 00:57, materoy@...ton.me wrote:
> From: Roy Matero <materoy@...ton.me>
> 
> Fix sorting of rust/bindings/binding_helper.h's includes,
> to maintain consistency and rust idoms
> 
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1002
> 
> Signed-off-by: Roy Matero <materoy@...ton.me>

A couple of nits for the commit message (these can be
applied by Miguel when picking the patch, if he agrees):
- capitalize 'Rust',
- add a `.` at the end,
- remove the newline between the tags.

I am not sure if the tags at the end should be sorted in any
way.

Reviewed-by: Benno Lossin <benno.lossin@...ton.me>

> ---
>   rust/bindings/bindings_helper.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index 50e7a76d5455..dc8d97272e71 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -6,10 +6,10 @@
>    * Sorted alphabetically.
>    */
> 
> -#include <linux/slab.h>
>   #include <linux/refcount.h>
> -#include <linux/wait.h>
>   #include <linux/sched.h>
> +#include <linux/slab.h>
> +#include <linux/wait.h>
> 
>   /* `bindgen` gets confused at certain things. */
>   const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;
> --
> 2.40.1
> 

-- 
Cheers,
Benno