linux-kernel - Re: [PATCH v4 2/3] arm64: dts: ti: k3-j721e: Add ESM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82a39b8e-96ad-faa2-714f-c8c6bfbcc5d6@ti.com>
Date:   Wed, 3 May 2023 17:25:27 +0530
From:   Neha Malcom Francis <n-francis@...com>
To:     Nishanth Menon <nm@...com>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <vigneshr@...com>,
        <kristo@...nel.org>, <u-kumar1@...com>
Subject: Re: [PATCH v4 2/3] arm64: dts: ti: k3-j721e: Add ESM support

Hi Nishanth,

On 03/05/23 17:18, Nishanth Menon wrote:
> On 15:03-20230503, Neha Malcom Francis wrote:
>> Add address entry mapping ESM on J721E.
>>
>> Signed-off-by: Neha Malcom Francis <n-francis@...com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721e.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e.dtsi b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
>> index b912143b6a11..52bcde601eb8 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
> 
> Why is'nt esm node introduced here?
> 

As it stands esm node is already in 
arch/arm/dts/k3-j721e-r5-common-proc-board.dts in u-boot and since this 
patch is motivated to keep the u-boot and kernel dts in sync, I haven't 
added it here.

Although... I could add it here similar to j7200 and take action to move 
to the same in u-boot... maybe that is better route.

>> @@ -131,6 +131,7 @@ cbass_main: bus@...000 {
>>   		#size-cells = <2>;
>>   		ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
>>   			 <0x00 0x00600000 0x00 0x00600000 0x00 0x00031100>, /* GPIO */
>> +			 <0x00 0x00700000 0x00 0x00700000 0x00 0x00001000>, /* ESM */
>>   			 <0x00 0x00900000 0x00 0x00900000 0x00 0x00012000>, /* serdes */
>>   			 <0x00 0x00a40000 0x00 0x00a40000 0x00 0x00000800>, /* timesync router */
>>   			 <0x00 0x06000000 0x00 0x06000000 0x00 0x00400000>, /* USBSS0 */
>> -- 
>> 2.34.1
>>
> 

-- 
Thanking You
Neha Malcom Francis