linux-kernel - Re: [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to xlnx,zynqmp-dpdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2023 15:27:03 +0200
From:   Michal Simek <michal.simek@....com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu,
        michal.simek@...inx.com, git@...inx.com,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Vinod Koul <vkoul@...nel.org>, devicetree@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to
 xlnx,zynqmp-dpdma

Hi,

On 5/3/23 14:51, Laurent Pinchart wrote:
> Hi Michal,
> 
> Thank you for the patch.
> 
> On Wed, May 03, 2023 at 10:00:20AM +0200, Michal Simek wrote:
>> DP DMA has own power domain that's why describe optional power-domain
>> property.
> 
> As far as I understand, the property should always be specified, the
> only reason why it's not mandatory is backward-compatibility (I would
> make it mandatory, as I think proper validation of new DT is more
> important than avoiding breaking validation - but not operation! - of
> old DT, but that's a separate story). If my understanding is correct,
> could you please update the example in the bindings to add the
> power-domains property ?

backward compatible - of course
always specified - if pd driver is enabled it must be there. If not it doesn't 
do anything - just describes it.

I am not in a position to decide this. But if dt folks agree with your ask I am 
happy to make it mandatory and extend example.

M