linux-kernel - Re: [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VekkTVzVCJs10GEi=1Andb2rWTwK8RELw6SqMzKYCPq2w@mail.gmail.com>
Date:   Wed, 3 May 2023 16:53:50 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Rohit Agarwal <quic_rohiagar@...cinc.com>
Cc:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        linus.walleij@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, richardcochran@...il.com,
        manivannan.sadhasivam@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver

On Wed, May 3, 2023 at 2:14 PM Rohit Agarwal <quic_rohiagar@...cinc.com> wrote:
> On 5/3/2023 3:11 PM, Andy Shevchenko wrote:
> > On Wed, May 3, 2023 at 8:39 AM Rohit Agarwal <quic_rohiagar@...cinc.com> wrote:

...

> >>   /**
> >>    * struct msm_function - a pinmux function
> >> - * @name:    Name of the pinmux function.
> >> - * @groups:  List of pingroups for this function.
> >> - * @ngroups: Number of entries in @groups.
> >> + * @func: Generic data of the pin function (name and groups of pins)
> >>    */
> >>   struct msm_function {
> >> -       const char *name;
> >> -       const char * const *groups;
> >> -       unsigned ngroups;
> >> +       struct pinfunction func;
> >>   };
> > But why? Just kill the entire structure.
> Got it. Can we have a typedef for pinfunction to msm_function in the msm
> header file?

But why? You can replace the type everywhere it needs to be replaced.
I can't expect many lines to change.

Also consider splitting struct pingroup change out of this. We will
focus only on the struct pinfunction change and less code to review.

-- 
With Best Regards,
Andy Shevchenko