linux-kernel - Re: [PATCH] nvme: add cond_resched() to nvme_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230503160752.GA683@lst.de>
Date:   Wed, 3 May 2023 18:07:52 +0200
From:   Christoph Hellwig <hch@....de>
To:     jiweisun126@....com
Cc:     linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kbusch@...nel.org, axboe@...com, hch@....de, sagi@...mberg.me,
        ahuang12@...ovo.com, sunjw10@...ovo.com
Subject: Re: [PATCH] nvme: add cond_resched() to nvme_complete_batch()

On Tue, May 02, 2023 at 08:54:12PM +0800, jiweisun126@....com wrote:
> From: Jiwei Sun <sunjw10@...ovo.com>
> 
> A soft lockup issue will be triggered when do fio test on a 448-core
> server, such as the following warning:

nvme_complete_batch can be called from irq context, so I don't think
a cond_resched is a good idea here.