linux-kernel - Re: [PATCH v2 2/2] cxl/region: Remove else after return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4cd9ff666fdbb2d0ff31736ad61b3475d6f4b26.camel@intel.com>
Date:   Wed, 3 May 2023 17:58:31 +0000
From:   "Verma, Vishal L" <vishal.l.verma@...el.com>
To:     "bwidawsk@...nel.org" <bwidawsk@...nel.org>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "Schofield, Alison" <alison.schofield@...el.com>,
        "raghuhack78@...il.com" <raghuhack78@...il.com>,
        "Weiny, Ira" <ira.weiny@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] cxl/region: Remove else after return statement

On Mon, 2023-05-01 at 07:53 -0700, Dave Jiang wrote:
> 
> 
> On 4/27/23 6:22 PM, Raghu H wrote:
> > Issue found with checkpatch
> > 
> > The else section here is redundant after return statement, removing it.
> > Sanity and correctness is not affected due to this fix.
> > 
> > Signed-off-by: Raghu H <raghuhack78@...il.com>
> 
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> 
> > ---
> >   drivers/cxl/core/region.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)

Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>

> > 
> > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> > index f29028148806..a46d6ad9ef0a 100644
> > --- a/drivers/cxl/core/region.c
> > +++ b/drivers/cxl/core/region.c
> > @@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
> >                                 "Bypassing cpu_cache_invalidate_memregion() for testing!\n");
> >                         clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
> >                         return 0;
> > -               } else {
> > -                       dev_err(&cxlr->dev,
> > -                               "Failed to synchronize CPU cache state\n");
> > -                       return -ENXIO;
> >                 }
> > +
> > +               dev_err(&cxlr->dev,
> > +                       "Failed to synchronize CPU cache state\n");
> > +               return -ENXIO;
> >         }
> >   
> >         cpu_cache_invalidate_memregion(IORES_DESC_CXL);