linux-kernel - Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 May 2023 13:30:26 -0500
From:   "Limonciello, Mario" <mlimonci@....com>
To:     Hamza Mahfooz <hamza.mahfooz@....com>,
        amd-gfx@...ts.freedesktop.org
Cc:     Alan Liu <HaoPing.Liu@....com>, Mukul Joshi <mukul.joshi@....com>,
        Tao Zhou <tao.zhou1@....com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Le Ma <le.ma@....com>,
        Stanley Yang <Stanley.Yang@....com>,
        Daniel Vetter <daniel@...ll.ch>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...il.com>,
        Christian König <christian.koenig@....com>,
        Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()


On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
> As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
> amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
> ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
> is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it
> from gmc_v9_0_hw_fini().
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
> Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 290804a06e05..6ae5cee9b64b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1999,7 +1999,6 @@ static int gmc_v9_0_hw_fini(void *handle)
>   	if (adev->mmhub.funcs->update_power_gating)
>   		adev->mmhub.funcs->update_power_gating(adev, false);
>   
> -	amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
>   	amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
>   
>   	return 0;