linux-kernel - Re: [PATCH] platform/x86: asus-wmi: add support for ASUS screenpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <R0Q3UR.1AXX7YQ75CIN1@ljones.dev>
Date:   Thu, 04 May 2023 09:22:03 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Barnabás Pőcze <pobrn@...tonmail.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net, hdegoede@...hat.com,
        corentin.chary@...il.com, markgross@...nel.org, jdelvare@...e.com,
        linux@...ck-us.net
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for ASUS screenpad



On Wed, May 3 2023 at 17:46:53 +0000, Barnabás Pőcze 
<pobrn@...tonmail.com> wrote:
> Hi
> 
> 
> 2023. május 3., szerda 6:02 keltezéssel, Luke D. Jones 
> <luke@...nes.dev> írta:
> 
>>  Add support for the WMI methods used to turn off and adjust the
>>  brightness of the secondary "screenpad" device found on some 
>> high-end
>>  ASUS laptops like the GX650P series and others.
> 
> Is it this one: https://www.asus.com/content/rog-screenpad-plus/ ?
> Or is the "plus" version something different?
> 
> If it's a "proper" screen, wouldn't it be better to add support for it
> in the respective subsystems? E.g. why not register a backlight 
> device?

I think it is similar yes, likely the same thing.

Adding as a proper backlight is what I wanted to do but at first blush 
I wasn't sure.

Looking at include/linux/backlight.h + some examples it looks clear 
now. I'll try to
work up a revised patch and get it tested by the folks with the actual 
laptop.

My only possible issue would be how to handle the on/off part?

Cheers,
Luke.