linux-kernel - Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2023 15:03:07 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        raghuhack78@...il.com
Cc:     linux-cxl@...r.kernel.org, ira.weiny@...el.com,
        bwidawsk@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed
 mem alloc

On Wed, May 03, 2023 at 08:32:37PM +0200, Fabio wrote:
> On venerdì 28 aprile 2023 03:22:34 CEST Raghu H wrote:
> > Issue found with checkpatch
> > 
> > A return of errno should be good enough if the memory allocation fails,
> > the error message here is redundatant
> 
> Typo: it's "redundant". No problem, I think you shouldn't resend only for the 
> purpose to fix this. But...
> 

Raghu,
checkpatch --codespell will catch misspellings in the commit log, when
run on the HEAD^ commit or on the formatted patch file.

> > as per the coding style, removing it.
> > 
> > Signed-off-by: Raghu H <raghuhack78@...il.com>
> 
> Is "Raghu H" the name you sign legal documents with? 
> 

Fabio,
Rather than asking a specific question to determine if this is a
valid SOB, let's just point folks to the documentation to figure
it out themselves. I'm aware that the 'sign legal documents' test
has been used in the past, but kernel only actually requires a
known identity.

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
https://github.com/cncf/foundation/blob/659fd32c86dc/dco-guidelines.md



> If not, please send a new version signed-off-by your full legal name. 
> Otherwise... sorry for the noise.
> 
> Thanks,
> 
> Fabio
> 
> > ---
> >  drivers/cxl/core/mbox.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index f2addb457172..11ea145b4b1f 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct
> > device *dev) struct cxl_dev_state *cxlds;
> > 
> >  	cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
> > -	if (!cxlds) {
> > -		dev_err(dev, "No memory available\n");
> > +	if (!cxlds)
> >  		return ERR_PTR(-ENOMEM);
> > -	}
> > 
> >  	mutex_init(&cxlds->mbox_mutex);
> >  	mutex_init(&cxlds->event.log_lock);
> > --
> > 2.39.2
> 
> 
> 
>