[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230504142727.4bd2206a@jacob-builder>
Date: Thu, 4 May 2023 14:27:27 -0700
From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
Robin Murphy <robin.murphy@....com>,
Jason Gunthorpe <jgg@...dia.com>,
Lu Baolu <baolu.lu@...ux.intel.com>,
Joerg Roedel <joro@...tes.org>,
"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
"vkoul@...nel.org" <vkoul@...nel.org>,
Will Deacon <will@...nel.org>,
David Woodhouse <dwmw2@...radead.org>,
"Raj, Ashok" <ashok.raj@...el.com>,
"Liu, Yi L" <yi.l.liu@...el.com>,
"Yu, Fenghua" <fenghua.yu@...el.com>,
"Jiang, Dave" <dave.jiang@...el.com>,
"Luck, Tony" <tony.luck@...el.com>,
"Zanussi, Tom" <tom.zanussi@...el.com>,
"Ranganathan, Narayan" <narayan.ranganathan@...el.com>,
jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v5 4/7] iommu/vt-d: Factoring out PASID set up helper
function
Hi Kevin,
On Fri, 28 Apr 2023 09:47:45 +0000, "Tian, Kevin" <kevin.tian@...el.com>
wrote:
> > From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> > Sent: Friday, April 28, 2023 1:50 AM
> >
> >
> > +static int dmar_domain_attach_device_pasid(struct dmar_domain *domain,
> > + struct intel_iommu *iommu,
> > + struct device *dev,
> > ioasid_t pasid) +{
> > + int ret;
> > +
> > + /* PASID table is mandatory for a PCI device in scalable mode.
> > */
> > + if (!sm_supported(iommu) && dev_is_real_dma_subdevice(dev))
> > + return -EOPNOTSUPP;
>
> "&&" should be "||"
>
good catch,
Thanks,
Jacob
Powered by blists - more mailing lists