linux-kernel - Re: [PATCH] vfio/pci: demote hiding ecap messages to debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230504170111.70a7f639.alex.williamson@redhat.com>
Date:   Thu, 4 May 2023 17:01:11 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Oleksandr Natalenko <oleksandr@...alenko.name>
Cc:     linux-kernel@...r.kernel.org, Eric Auger <eric.auger@...hat.com>,
        Cédric Le Goater <clg@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Abhishek Sahu <abhsahu@...dia.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Cornelia Huck <cohuck@...hat.com>, Bo Liu <liubo03@...pur.com>,
        "K V P, Satyanarayana" <satyanarayana.k.v.p@...el.com>,
        kvm@...r.kernel.org
Subject: Re: [PATCH] vfio/pci: demote hiding ecap messages to debug level

On Thu,  4 May 2023 15:16:54 +0200
Oleksandr Natalenko <oleksandr@...alenko.name> wrote:

> Seeing a burst of messages like this:
> 
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@...d0
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@...00
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@...10
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@...50
>     vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@...00
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@...d0
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@...00
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@...10
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@...50
>     vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@...00
> 
> is of little to no value for an ordinary user.
> 
> Hence, use pci_dbg() instead of pci_info().
> 
> Signed-off-by: Oleksandr Natalenko <oleksandr@...alenko.name>
> ---
>  drivers/vfio/pci/vfio_pci_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 948cdd464f4e..dd8dda14e701 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev)
>  		}
>  
>  		if (!len) {
> -			pci_info(pdev, "%s: hiding ecap %#x@%#x\n",
> +			pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n",
>  				 __func__, ecap, epos);
>  
>  			/* If not the first in the chain, we can skip over it */

Looks fine to me, though I might adjust that next line to keep the
previous alignment.  In general this has certainly caused more
confusion than insightful information, so demoting it to debug is a
good idea.  Thanks,

Alex