linux-kernel - RE:(2) [PATCH 02/15] block: blk-integiry: add helper functions for bio_integrity_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230504064656epcms2p79ffe075ea27710f311b8c1738ed10be0@epcms2p7>
Date:   Thu, 04 May 2023 15:46:56 +0900
From:   Jinyoung CHOI <j-young.choi@...sung.com>
To:     "hch@....de" <hch@....de>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE:(2) [PATCH 02/15] block: blk-integiry: add helper functions for
 bio_integrity_add_page

>s/blk-integiry/blk-integrity/ in the subject.
>
>> +static inline bool bip_full(struct bio_integrity_payload *bip, unsigned int len)
>
>> +static bool bip_try_merge_hw_seg(struct request_queue *q,
>> +                                 struct bio_integrity_payload *bip,
>> +                                 struct page *page, unsigned int len,
>> +                                 unsigned int offset, bool *same_page)
>
>... but adding static functions without users will cause a compile
>error anyway, so I'd suggest to just merge it into the patch adding
>users.
>
>But I wonder if we really want to duplicate all this logic anyway.
>If we passed a bio_vec array, the vec count and an iter, we should
>be able to just share the logic with the bio data payload.

Thank you, Christoph.

I made a mistake while dividing the patch. I will be careful.
I will merge with the code that uses the function and put it on the next patch.

And as you mentioned, it is duplicated with the configuration of bio's data payload.
I will improve this by reflecting your proposal.

Best regards,
Jinyoung.