linux-kernel - Re: [PATCH] iio: addac: ad74413: fix resistance input processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50a65435aedd208e4980938ed191c2a281c5015e.camel@gmail.com>
Date:   Thu, 04 May 2023 09:09:52 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Cosmin Tanislav <demonsingur@...il.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: addac: ad74413: fix resistance input processing

On Wed, 2023-05-03 at 11:58 +0200, Rasmus Villemoes wrote:
> On success, ad74413r_get_single_adc_result() returns IIO_VAL_INT aka
> 1. So currently, the IIO_CHAN_INFO_PROCESSED case is effectively
> equivalent to the IIO_CHAN_INFO_RAW case, and we never call
> ad74413r_adc_to_resistance_result() to convert the adc measurement to
> ohms.
> 
> Check ret for being negative rather than non-zero.
> 
> Fixes: fea251b6a5dbd (iio: addac: add AD74413R driver)
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/addac/ad74413r.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
> index 07e9f6ae16a8..e3366cf5eb31 100644
> --- a/drivers/iio/addac/ad74413r.c
> +++ b/drivers/iio/addac/ad74413r.c
> @@ -1007,7 +1007,7 @@ static int ad74413r_read_raw(struct iio_dev *indio_dev,
>  
>                 ret = ad74413r_get_single_adc_result(indio_dev, chan->channel,
>                                                      val);
> -               if (ret)
> +               if (ret < 0)
>                         return ret;
>  
>                 ad74413r_adc_to_resistance_result(*val, val);