linux-kernel - [PATCH 1/1] kernel/smp: Fix comments for smp_call_function{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  4 May 2023 15:20:50 +0800
From:   Qiuxu Zhuo <qiuxu.zhuo@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>
Cc:     Qiuxu Zhuo <qiuxu.zhuo@...el.com>, linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] kernel/smp: Fix comments for smp_call_function{,_many}()

The parameter 'wait' of smp_call_function_many() is a bool, not a
bitmask. smp_call_function() has no return value. Fix their function
comments respectively.

Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
---
 kernel/smp.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/smp.c b/kernel/smp.c
index 06a413987a14..ee4f3439b7d5 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -994,10 +994,8 @@ static void smp_call_function_many_cond(const struct cpumask *mask,
  * @mask: The set of cpus to run on (only runs on online subset).
  * @func: The function to run. This must be fast and non-blocking.
  * @info: An arbitrary pointer to pass to the function.
- * @wait: Bitmask that controls the operation. If %SCF_WAIT is set, wait
- *        (atomically) until function has completed on other CPUs. If
- *        %SCF_RUN_LOCAL is set, the function will also be run locally
- *        if the local CPU is set in the @cpumask.
+ * @wait: If true, wait (atomically) until function has completed
+ *        on other CPUs.
  *
  * If @wait is true, then returns once @func has returned.
  *
@@ -1019,8 +1017,6 @@ EXPORT_SYMBOL(smp_call_function_many);
  * @wait: If true, wait (atomically) until function has completed
  *        on other CPUs.
  *
- * Returns 0.
- *
  * If @wait is true, then returns once @func has returned; otherwise
  * it returns just before the target cpu calls @func.
  *
-- 
2.17.1