linux-kernel - Re: [PATCH v5 1/3] dt-bindings: misc: esm: Add ESM support for TI K3 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 May 2023 13:13:23 +0530
From:   Neha Malcom Francis <n-francis@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <u-kumar1@...com>
Subject: Re: [PATCH v5 1/3] dt-bindings: misc: esm: Add ESM support for TI K3
 devices

Hi Krzysztof

On 04/05/23 12:21, Krzysztof Kozlowski wrote:
> On 03/05/2023 14:32, Neha Malcom Francis wrote:
>> Document the binding for TI K3 ESM (Error Signaling Module) block.
>>
>> Signed-off-by: Neha Malcom Francis <n-francis@...com>
> 
> ???
> 
> You were already asked to keep it and it was in v4, so you had to
> explicitly remove it from your git... It takes me time to figure out
> what is happening here. But ok, if you do not keep my review, comment
> follows.
> 
> ...

Really sorry about that, forgot to add it back for v5. Sending next 
version soon...

> 
>> +  ti,esm-pins:
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +    description:
>> +      integer array of ESM interrupt pins to route to external event pin
>> +      which can be used to reset the SoC.
>> +    minItems: 1
>> +    maxItems: 255
>> +
>> +additionalProperties: false
> 
> Put aditionalProperties after required:, just like in example-schema.
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - ti,esm-pins
> 
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Thanking You
Neha Malcom Francis