linux-kernel - Re: [PATCH] lkdtm: replace ll_rw_block with submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <645306fa.620a0220.a363f.f9d0@mx.google.com>
Date:   Wed, 3 May 2023 18:14:33 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Yue Zhao <findns94@...il.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lkdtm: replace ll_rw_block with submit_bh

On Thu, May 04, 2023 at 12:29:44AM +0800, Yue Zhao wrote:
> Function ll_rw_block was removed in commit 79f597842069 ("fs/buffer:
> remove ll_rw_block() helper"). There is no unified function to sumbit
> read or write buffer in block layer for now. Consider similar sematics,
> we can choose submit_bh() to replace ll_rw_block() as predefined crash
> point. In submit_bh(), it also takes read or write flag as the first
> argument and invoke submit_bio() to submit I/O request to block layer.
> 
> Fixes: 79f597842069 ("fs/buffer: remove ll_rw_block() helper")
> 
> Signed-off-by: Yue Zhao <findns94@...il.com>

Acked-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook