linux-kernel - Re: [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check overflow interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFNplb0IYONNPtAU@localhost.localdomain>
Date:   Thu, 4 May 2023 10:15:17 +0200
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...nel.org>, Qais Yousef <qyousef@...alina.io>,
        Waiman Long <longman@...hat.com>, Tejun Heo <tj@...nel.org>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Hao Luo <haoluo@...gle.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org, luca.abeni@...tannapisa.it,
        claudio@...dence.eu.com, tommaso.cucinotta@...tannapisa.it,
        bristot@...hat.com, mathieu.poirier@...aro.org,
        cgroups@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Wei Wang <wvw@...gle.com>, Rick Yiu <rickyiu@...gle.com>,
        Quentin Perret <qperret@...gle.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check
 overflow interface

On 04/05/23 08:23, Peter Zijlstra wrote:
> On Wed, May 03, 2023 at 09:22:27AM +0200, Juri Lelli wrote:
> > From: Dietmar Eggemann <dietmar.eggemann@....com>
> > 
> > Rework the existing dl_cpu_busy() interface which offers DL BW overflow
> > checking and per-task DL BW allocation.
> > 
> > Add dl_bw_free() as an interface to be able to free DL BW.
> > It will be used to allow freeing of the DL BW request done during
> > cpuset_can_attach() in case multiple controllers are attached to the
> > cgroup next to the cpuset controller and one of the non-cpuset
> > can_attach() fails.
> > 
> > dl_bw_alloc() (and dl_bw_free()) now take a `u64 dl_bw` parameter
> > instead of `struct task_struct *p` used in dl_cpu_busy().  This allows
> > to allocate DL BW for a set of tasks too rater than only for a single
> > task.
> > 
> 
> Changlog fails the 'why' test.
> 

Dietmar, if you could please add (or rework) the 'why' as a reply to
this email, I can fold in v3.

Thanks!