linux-kernel - Re: [PATCH] devres: provide API devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023050445-blizzard-splendid-cf1c@gregkh>
Date:   Thu, 4 May 2023 18:08:46 +0900
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Peng Fan <peng.fan@....com>
Cc:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "saravanak@...gle.com" <saravanak@...gle.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "abel.vesa@...aro.org" <abel.vesa@...aro.org>
Subject: Re: [PATCH] devres: provide API devm_kstrndup

On Thu, May 04, 2023 at 08:59:41AM +0000, Peng Fan wrote:
> Hi Greg,
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Sent: 2023年5月4日 16:58
> > To: Peng Fan (OSS) <peng.fan@....nxp.com>
> > Cc: robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> > rafael@...nel.org; andriy.shevchenko@...ux.intel.com;
> > hdegoede@...hat.com; jgg@...pe.ca; saravanak@...gle.com;
> > keescook@...omium.org; tglx@...utronix.de; linux-kernel@...r.kernel.org;
> > abel.vesa@...aro.org; Peng Fan <peng.fan@....com>
> > Subject: Re: [PATCH] devres: provide API devm_kstrndup
> > 
> > On Thu, May 04, 2023 at 03:57:54PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > This patch introduces devm_kstrndup API so that the device's driver
> > > can allocate memory and copy string.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >  drivers/base/devres.c  | 28 ++++++++++++++++++++++++++++
> > > include/linux/device.h |  1 +
> > >  2 files changed, 29 insertions(+)
> > 
> > We can not add apis with no users, please submit this at the same time a
> > driver needs it.
> > 
> > And what driver would need to copy a string?
> 
> https://lore.kernel.org/all/20230504085506.504474-1-peng.fan@oss.nxp.com/

Please never add new module parameters, ESPECIALLY for a driver.  This
is not the 1990's anymore, please use the correct apis instead (hint,
sysfs, configfs, DT, etc.)

> Should I submit V2 with the upper patch in a patchset?

I can't take this as-is, for the reason I said, so yes.  And again, your
dependant patch is not ok either, so I don't think this is needed
anymore.

thanks,

greg k-h