linux-kernel - Re: [PATCH v2 2/2] dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 May 2023 12:49:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Hermes Zhang <chenhuiz@...s.com>, jic23@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...s.com, Lars-Peter Clausen <lars@...afoo.de>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: imu: mpu6050: Add icm20600
 bindings to mpu6050

On 04/05/2023 11:14, Hermes Zhang wrote:
> ICM-20600 is almost same as ICM-20602 which already support in mpu6050
> driver. Specify "invensense,icm20602" as a fallback compatible
> 
> Signed-off-by: Hermes Zhang <chenhuiz@...s.com>
> ---
> 
> Notes:
>     v2: require specifying "invensense,icm20602" as a fallback compatible
>         in the binding, as suggested
> 
>  .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> index ec64d7877fe5..711a1beeaecf 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> @@ -33,6 +33,9 @@ properties:
>        - items:
>            - const: invensense,icm20608d
>            - const: invensense,icm20608
> +      - items:
> +          - const: invensense,icm20600
> +          - const: invensense,icm20602

Don't stuff entries at the end. This should be rather before above
icm20608 entry.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof