| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 May 2023 18:58:13 +0800
From: kernel test robot <lkp@...el.com>
To: Jon Derrick <jonathan.derrick@...ux.dev>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Song Liu <song@...nel.org>, Christoph Hellwig <hch@....de>
Subject: drivers/md/md-bitmap.c:242 __write_sb_page() warn: unsigned 'offset'
is never less than zero.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1a5304fecee523060f26e2778d9d8e33c0562df3
commit: 10172f200b67aafcb9b8ce7d0575d713c1aafbb7 md: Fix types in sb writer
date: 3 weeks ago
config: nios2-randconfig-m031-20230503 (https://download.01.org/0day-ci/archive/20230504/202305041858.yfdVDDZ4-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305041858.yfdVDDZ4-lkp@intel.com/
New smatch warnings:
drivers/md/md-bitmap.c:242 __write_sb_page() warn: unsigned 'offset' is never less than zero.
Old smatch warnings:
arch/nios2/include/asm/thread_info.h:62 current_thread_info() error: uninitialized symbol 'sp'.
vim +/offset +242 drivers/md/md-bitmap.c
b2d2c4ceaddc30 drivers/md/bitmap.c NeilBrown 2008-09-01 211
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 212 static int __write_sb_page(struct md_rdev *rdev, struct bitmap *bitmap,
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 213 struct page *page)
a654b9d8f851f4 drivers/md/bitmap.c NeilBrown 2005-06-21 214 {
a6ff7e089c7fca drivers/md/bitmap.c Jonathan Brassow 2011-01-14 215 struct block_device *bdev;
fd01b88c75a718 drivers/md/bitmap.c NeilBrown 2011-10-11 216 struct mddev *mddev = bitmap->mddev;
1ec885cdd01a9a drivers/md/bitmap.c NeilBrown 2012-05-22 217 struct bitmap_storage *store = &bitmap->storage;
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 218 sector_t offset = mddev->bitmap_info.offset;
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 219 sector_t ps, sboff, doff;
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 220 unsigned int size = PAGE_SIZE;
a6ff7e089c7fca drivers/md/bitmap.c Jonathan Brassow 2011-01-14 221
a6ff7e089c7fca drivers/md/bitmap.c Jonathan Brassow 2011-01-14 222 bdev = (rdev->meta_bdev) ? rdev->meta_bdev : rdev->bdev;
9b1215c102d4b1 drivers/md/bitmap.c NeilBrown 2012-05-22 223 if (page->index == store->file_pages - 1) {
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 224 unsigned int last_page_size = store->bytes & (PAGE_SIZE - 1);
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 225
9b1215c102d4b1 drivers/md/bitmap.c NeilBrown 2012-05-22 226 if (last_page_size == 0)
9b1215c102d4b1 drivers/md/bitmap.c NeilBrown 2012-05-22 227 last_page_size = PAGE_SIZE;
9b1215c102d4b1 drivers/md/bitmap.c NeilBrown 2012-05-22 228 size = roundup(last_page_size,
a6ff7e089c7fca drivers/md/bitmap.c Jonathan Brassow 2011-01-14 229 bdev_logical_block_size(bdev));
9b1215c102d4b1 drivers/md/bitmap.c NeilBrown 2012-05-22 230 }
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 231
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 232 ps = page->index * PAGE_SIZE / SECTOR_SIZE;
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 233 sboff = rdev->sb_start + offset;
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 234 doff = rdev->data_offset;
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 235
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 236 /* Just make sure we aren't corrupting data or metadata */
f6af949c567211 drivers/md/bitmap.c NeilBrown 2009-12-14 237 if (mddev->external) {
f6af949c567211 drivers/md/bitmap.c NeilBrown 2009-12-14 238 /* Bitmap could be anywhere. */
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 239 if (sboff + ps > doff &&
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 240 sboff < (doff + mddev->dev_sectors + PAGE_SIZE / SECTOR_SIZE))
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 241 return -EINVAL;
f6af949c567211 drivers/md/bitmap.c NeilBrown 2009-12-14 @242 } else if (offset < 0) {
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 243 /* DATA BITMAP METADATA */
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 244 if (offset + ps + size / SECTOR_SIZE > 0)
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 245 /* bitmap runs in to metadata */
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 246 return -EINVAL;
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 247
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 248 if (doff + mddev->dev_sectors > sboff)
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 249 /* data runs in to bitmap */
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 250 return -EINVAL;
0f420358e3a2ab drivers/md/bitmap.c Andre Noll 2008-07-11 251 } else if (rdev->sb_start < rdev->data_offset) {
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 252 /* METADATA BITMAP DATA */
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 253 if (sboff + ps + size / SECTOR_SIZE > doff)
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 254 /* bitmap runs in to data */
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 255 return -EINVAL;
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 256 } else {
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 257 /* DATA METADATA BITMAP - no problems */
f0d76d70bc77b9 drivers/md/bitmap.c NeilBrown 2007-07-17 258 }
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 259
10172f200b67aa drivers/md/md-bitmap.c Jon Derrick 2023-02-24 260 md_super_write(mddev, rdev, sboff + ps, (int) size, page);
328e17d8d9428b drivers/md/md-bitmap.c Jon Derrick 2023-02-24 261 return 0;
ab6085c795a71b drivers/md/bitmap.c NeilBrown 2007-05-23 262 }
a654b9d8f851f4 drivers/md/bitmap.c NeilBrown 2005-06-21 263
:::::: The code at line 242 was first introduced by commit
:::::: f6af949c5672115313cc3c976d85b0533f607d7e md: support bitmap offset appropriate for external-metadata arrays.
:::::: TO: NeilBrown <neilb@...e.de>
:::::: CC: NeilBrown <neilb@...e.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists