linux-kernel - Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFMX0K4jeUIBOo7D@aschofie-mobl2>
Date:   Wed, 3 May 2023 19:26:24 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     Davidlohr Bueso <dave@...olabs.net>,
        Raghu H <raghuhack78@...il.com>
Cc:     linux-cxl@...r.kernel.org, ira.weiny@...el.com,
        bwidawsk@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed
 mem alloc

On Wed, May 03, 2023 at 03:36:50PM -0700, Davidlohr Bueso wrote:
> On Fri, 28 Apr 2023, Raghu H wrote:
> 
> > Issue found with checkpatch
> 
> fyi for both patches, these are not "issues" - you can remove it, or the line altogether.
> 
> Thanks,
> Davidlohr

Hi Raghu,

Perhaps this patchset got you more attention than you may have expected ;)
So, this is an example of when reviewers disagree. I asked you to note
that checkpatch found these 'issues' and David disagrees.

If David had known I'd asked you to update the commit log to include the
checkpatch credit, he may have ignored it, or maybe not. I don't find
the word 'issue' to be misused. There are many flavors of this phrase used
in kernel commit logs that address checkpatch found issues.

The way the next round of reviewers knows what the first round asked
for is by looking at the changelog. (And, if they need more detail, they
pull up the previous patchset discussion.)

The changelog in the cover letter, or per patch, needs to explicitly
say what has changed.

The v2 says this:

>> v2 changes:
>> Thanks Alison, Ira for your comments, modified the v1 patches as suggested.
>> Dropped the patch containing tab changes in port.c

Next time, be more specific, like this:

v2 changes:
- Update commit logs to credit checkpatch (Alison)
- Update commit msgs to conform to subsystem style (Alison)
- Drop the patch containing tab changes in port.c (Ira)

Thanks,
Alison