linux-kernel - [PATCH v3 0/1] Small fixes to the cyttsp5 touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  4 May 2023 14:03:15 +0200
From:   Maximilian Weigand <mweigand2017@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     Maximilian Weigand <mweigand@...igand.net>,
        Alistair Francis <alistair@...stair23.me>
Subject: [PATCH v3 0/1] Small fixes to the cyttsp5 touchscreen driver

From: Maximilian Weigand <mweigand@...igand.net>

Currently the cyttsp5 driver does not put the device to sleep during
suspend, which can have unwanted side effects if an irq trigger of type
EDGE_FALLING is used, as well as leads to increased power usage.

Correspondingly, sleep and wakeup commands to the touchscreen were
derived from the GPL-2 vendor/android driver by Cypress Semiconductor
(copyright note for Cypress Semiconductor is already in the current
driver).

Tested on the Pine64 PineNote.

Changes in v3:
- dropped patches 1,2,5: already applied in v2
- dropped patch 4 "Input: cyttsp5 - properly initialize the device as a
  pm wakeup device" - functionality is already taken care of in the
  kernel
- dropped patch 3 "dt-bindings: input: cypress,tt21000 - fix interrupt
  type in dts example": it was suggested that the driver should work
  with both interrupt types, falling edge and level low. Once a solution
  is found it will be submitted as a separate patch.
- reworked patch 6 "Input: cyttsp5 - implement proper sleep and wakeup
  procedures" in response to review comments:
	- use the existing completion instead of adding a new one for
	  sleep/wakeup command handling
	- use device_may_wakeup() to determine if the device should be
	  suspended upon entering standby
	- clarified commit message

Changes in v2:
- fix subject lines
- fix 'unused variable' errors reported by the kernel test robot
- clean up commit message of patch 2

Maximilian Weigand (1):
  Input: cyttsp5 - implement proper sleep and wakeup procedures

 drivers/input/touchscreen/cyttsp5.c | 118 ++++++++++++++++++++++++++++
 1 file changed, 118 insertions(+)


base-commit: 457391b0380335d5e9a5babdec90ac53928b23b4
--
2.39.2