linux-kernel - Re: [PATCH v4 3/3] io_uring: Remove unnecessary BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFPD0c2dxQT2N9+f@ovpn-8-16.pek2.redhat.com>
Date:   Thu, 4 May 2023 22:40:17 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     Breno Leitao <leitao@...ian.org>
Cc:     io-uring@...r.kernel.org, linux-nvme@...ts.infradead.org,
        asml.silence@...il.com, hch@....de, axboe@...nel.dk, leit@...com,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        sagi@...mberg.me, joshi.k@...sung.com, kbusch@...nel.org
Subject: Re: [PATCH v4 3/3] io_uring: Remove unnecessary BUILD_BUG_ON

On Thu, May 04, 2023 at 05:18:56AM -0700, Breno Leitao wrote:
> In the io_uring_cmd_prep_async() there is an unnecessary compilation time
> check to check if cmd is correctly placed at field 48 of the SQE.
> 
> This is unnecessary, since this check is already in place at
> io_uring_init():
> 
>           BUILD_BUG_SQE_ELEM(48, __u64,  addr3);
> 
> Remove it and the uring_cmd_pdu_size() function, which is not used
> anymore.
> 
> Keith started a discussion about this topic in the following thread:
> Link: https://lore.kernel.org/lkml/ZDBmQOhbyU0iLhMw@kbusch-mbp.dhcp.thefacebook.com/
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> Reviewed-by: Christoph Hellwig <hch@....de>

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,
Ming