linux-kernel - Re: [PATCH 7/7] dt-bindings: dmaengine: pl330: Add new quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 May 2023 17:08:38 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Joy Chakraborty <joychakr@...gle.com>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, manugautam@...gle.com,
        danielmentz@...gle.com, sjadavani@...gle.com
Subject: Re: [PATCH 7/7] dt-bindings: dmaengine: pl330: Add new quirks

On 04/05/2023 16:57, Joy Chakraborty wrote:
> Add 2 new quirks added to the driver "arm,pl330-optimize-dev2mem-axsize"
> and "arm,pl330-periph-single-dregs"

This we can see from the diff. You need to answer why?

> 
> Signed-off-by: Joy Chakraborty <joychakr@...gle.com>
> ---
>  Documentation/devicetree/bindings/dma/arm,pl330.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/arm,pl330.yaml b/Documentation/devicetree/bindings/dma/arm,pl330.yaml
> index 4a3dd6f5309b..0499a7fba88d 100644
> --- a/Documentation/devicetree/bindings/dma/arm,pl330.yaml
> +++ b/Documentation/devicetree/bindings/dma/arm,pl330.yaml
> @@ -53,6 +53,14 @@ properties:
>      type: boolean
>      description: quirk for performing burst transfer only
>  
> +  arm,pl330-optimize-dev2mem-axsize:
> +    type: boolean
> +    description: quirk for optimizing AxSize used between dev<->mem

This tells me nothing... Neither what it is about nor why this is
property of a board or PL330 hardware implementation. Please describe
hardware, not drivers.

> +
> +  arm,pl330-periph-single-dregs:
> +    type: boolean
> +    description: quirk for using dma-singles for peripherals in _dregs()

Same concerns.


Best regards,
Krzysztof