linux-kernel - Re: [PATCH] maple_tree: Make maple state reusable after mas_empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560c0037f71be3b0bfe0109ace30cfb869dc7382.camel@intel.com>
Date:   Thu, 4 May 2023 19:10:05 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "Stable@...r.kernel.org" <Stable@...r.kernel.org>,
        "support@...tco.us" <support@...tco.us>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mgkeyes@...ovproductions.net" <mgkeyes@...ovproductions.net>
Subject: Re: [PATCH] maple_tree: Make maple state reusable after
 mas_empty_area()

On Thu, 2023-05-04 at 13:55 -0400, Liam R. Howlett wrote:
> Do not update the min and max of the maple state to the slot of the
> leaf
> node.  Leaving the min and max to the node entry allows for the maple
> state to be used in other operations.
> 
> Users would get unexpected results from other operations on the maple
> state after calling the affected function.
> 
> Reported-by: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
> Reported-by: Tad <support@...tco.us>
> Reported-by: Michael Keyes <mgkeyes@...ovproductions.net>
> Link:
> https://lore.kernel.org/linux-mm/32f156ba80010fd97dbaf0a0cdfc84366608624d.camel@intel.com/
> Link:
> https://lore.kernel.org/linux-mm/e6108286ac025c268964a7ead3aab9899f9bc6e9.camel@spotco.us/
> Fixes: Fixes: 54a611b60590 ("Maple Tree: add new data structure")
> Cc: <Stable@...r.kernel.org>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> ---

This fixes it for all the cases I encountered, thanks!