linux-kernel - Re: [RFC PATCH 5/7] x86/resctrl: Enhance driver registration to hook into schemata files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2023 16:20:00 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Shaopeng Tan <tan.shaopeng@...itsu.com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        James Morse <james.morse@....com>,
        "Babu Moger" <babu.moger@....com>
CC:     <x86@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 5/7] x86/resctrl: Enhance driver registration to hook
 into schemata files

Hi Tony,

On 4/20/2023 3:06 PM, Tony Luck wrote:
> Add a new configuration type "DRIVER" for lines in the schemata files
> with a show() and update() callback functions to the driver to maintain
> these lines.

If the goal is to have unique APIs for resource, could an alternative
be the have show() and update() callbacks associated with resources in
resctrl self?

...

> @@ -2390,6 +2392,9 @@ static int schemata_list_add(struct rdt_resource *r, enum resctrl_conf_type type
>  	case CDP_NONE:
>  		suffix = "";
>  		break;
> +	case DRIVER:
> +		kfree(s);
> +		return -EINVAL;
>  	}
>  

(This could perhaps be simplified to not allocate the memory in the first place?)

Reinette