[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 May 2023 12:24:13 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
vkoul@...nel.org, kishon@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, gregkh@...uxfoundation.org,
mturquette@...libre.com, sboyd@...nel.org, quic_wcheng@...cinc.com,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v10 9/9] arm64: dts: qcom: ipq9574: Enable USB
On Fri, 5 May 2023 at 11:24, Varadarajan Narayanan
<quic_varada@...cinc.com> wrote:
>
> Turn on USB related nodes
> Provide vdd info
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> Changes in v10:
> - Provide vdd info
>
> Changes in v5:
> - Move "host" mode specification to board dts
> - Due to dependency with earlier patches board dts
> filename changed ipq9574-al02-c7.dts -> ipq9574-rdp433.dts
>
> Changes in v2:
> - Fix node placement and coding style
> - "ok" -> "okay"
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> index 1f5d14f..18d642c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> @@ -70,6 +70,10 @@
> };
> };
>
> +&dwc_0 {
If the node alias was usb_0_dwc3, it would have been next to the main
usb_0 node. Could you please fix the alias.
> + dr_mode = "host";
> +};
> +
> &pcie1_phy {
> status = "okay";
> };
> @@ -122,6 +126,21 @@
> clock-frequency = <32000>;
> };
>
> +&usb_0_qmpphy {
> + vdda-pll-supply = <&mp5496_l2>;
> + vdda-phy-supply = <&fixed_0p925>;
> +
> + status = "okay";
> +};
> +
> +&usb_0_qusbphy {
> + vdd-supply = <&fixed_0p925>;
> + vdda-pll-supply = <&mp5496_l2>;
> + vdda-phy-dpdm-supply = <&fixed_3p3>;
> +
> + status = "okay";
> +};
> +
> &tlmm {
If sorted alphabetically, 'u' comes after 't', so these two chunks are
out of order and should be fixed.
>
> pcie_1_pin: pcie-1-state {
> @@ -188,6 +207,10 @@
> };
> };
>
> +&usb3 {
> + status = "okay";
> +};
> +
> &xo_board_clk {
> clock-frequency = <24000000>;
> };
> --
> 2.7.4
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists