linux-kernel - Re: [PATCH] media: nxp: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 May 2023 12:27:47 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     mchehab@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] media: nxp: remove unneeded semicolon

Hi Jiapeng,

Thank you for the patch.

On Fri, May 05, 2023 at 02:06:17PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:226:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4868
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

I'll update the subject line to

media: nxp: imx8-isi: Remove unneeded semicolon

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index b5ffde46f31b..f7447b2f4d77 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -223,7 +223,7 @@ static int mxc_isi_crossbar_init_cfg(struct v4l2_subdev *sd,
>  		route->sink_pad = i;
>  		route->source_pad = i + xbar->num_sinks;
>  		route->flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE;
> -	};
> +	}
>  
>  	routing.num_routes = xbar->num_sources;
>  	routing.routes = routes;

-- 
Regards,

Laurent Pinchart