linux-kernel - Re: [PATCH 3/3] Documentation: scsi: dc395x: Remove reference to 2.4 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2023 20:12:08 +1000 (AEST)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
cc:     Linux SCSI <linux-scsi@...r.kernel.org>,
        Linux Documentation <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kernel Janitors <kernel-janitors@...r.kernel.org>,
        Oliver Neukum <oliver@...kum.org>,
        Ali Akcaagac <aliakc@....de>,
        Jamie Lenehan <lenehan@...bble.org>,
        Jonathan Corbet <corbet@....net>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH 3/3] Documentation: scsi: dc395x: Remove reference to
 2.4 driver

On Fri, 5 May 2023, Bagas Sanjaya wrote:

> The 2.4 driver link returns 404. 

It's still potentially useful:
https://web.archive.org/web/20140129181343/http://www.garloff.de/kurt/linux/dc395/

> As no one runs 2.4 kernel anymore,

Would it make a difference if someone does run that? Were you planning to 
delete the source code for the 2.4 kernel too?

> remove the stale reference.
> 

It was always stale inasmuch as it is apparently there to give credit for 
prior contributions, plus a changelog (see archive.org).

Any published link should probably be accompanied by a "retrieved on 
yyyy-mm-dd" qualification. But no qualification is better than no link at 
all, IMO.

Of course, there is a reason for an edit here. Yet it's not the one you 
gave. "This is a 2.5 only driver" is simply incorrect. (If it was correct 
you'd get to delete the whole thing.)

This is not a nak as I'm not the maintainer. But this patch just looks 
like churn with no justification. Perhaps I'm not the only one who can't 
see it.

> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  Documentation/scsi/dc395x.rst | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/Documentation/scsi/dc395x.rst b/Documentation/scsi/dc395x.rst
> index c413b629809bcd..a6320561543650 100644
> --- a/Documentation/scsi/dc395x.rst
> +++ b/Documentation/scsi/dc395x.rst
> @@ -11,10 +11,6 @@ be safe to use. Testing with hard disks has not been done to any
>  great degree and caution should be exercised if you want to attempt
>  to use this driver with hard disks.
>  
> -This is a 2.5 only driver. For a 2.4 driver please see the original
> -driver (which this driver started from) at
> -http://www.garloff.de/kurt/linux/dc395/
> -
>  Problems, questions and patches should be submitted to the `Linux SCSI
>  mailing list <linux-scsi@...r.kernel.org>`_.
>  
>