linux-kernel - Re: [PATCH] gpio: zynq: fix zynqmp_gpio not an immutable chip warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 May 2023 13:56:42 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@....com>
Cc:     michal.simek@...inx.com, michal.simek@....com, git@....com,
        shubhrajyoti.datta@...inx.com, srinivas.neeli@...inx.com,
        brgl@...ev.pl, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        srinivas.goud@....com, manion05gk@...il.com
Subject: Re: [PATCH] gpio: zynq: fix zynqmp_gpio not an immutable chip warning

Hi Manikanta,

thanks for your patch!

On Wed, Apr 12, 2023 at 4:52 PM Manikanta Guntupalli
<manikanta.guntupalli@....com> wrote:

> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE to fix
> "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>

Don't you need to also add
gpiochip_disable_irq() in the .irq_mask() callback and
gpiochip_enable_irq() in the .irq_unmask() callback as we
do in most other conversions?

Example:
https://lore.kernel.org/linux-gpio/20230414-immutable-irqchips-2-v1-3-6b59a5186b00@linaro.org/

Yours,
Linus Walleij