[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 May 2023 17:37:33 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Vinod Koul <vkoul@...nel.org>, Tom Rix <trix@...hat.com>
Cc: chunkuang.hu@...nel.org, p.zabel@...gutronix.de,
chunfeng.yun@...iatek.com, kishon@...nel.org,
angelogioacchino.delregno@...labora.com, nathan@...nel.org,
ndesaulniers@...gle.com, granquet@...libre.com,
dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev
Subject: Re: [PATCH] phy: mediatek: fix returning garbage
On 05/05/2023 11:28, Vinod Koul wrote:
> On 14-04-23, 08:22, Tom Rix wrote:
>> clang reports
>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
>> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>> if (ret)
>> ^~~
>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>
> I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
> usage in pll_calc"
Thanks Vinod, that was on my list for today as well. I was a bit puzzled because
you took the patch that added it, but I wasn't sure if you would take the fix.
How do you want to handle things like this in the future?
Regards,
Matthias
Powered by blists - more mailing lists