[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 May 2023 13:37:43 -0400
From: Ross Philipson <ross.philipson@...cle.com>
To: Simon Horman <horms@...nel.org>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
linux-integrity@...r.kernel.org, linux-doc@...r.kernel.org,
linux-crypto@...r.kernel.org, iommu@...ts.linux-foundation.org,
kexec@...ts.infradead.org, linux-efi@...r.kernel.org,
dpsmith@...rtussolutions.com, tglx@...utronix.de, mingo@...hat.com,
bp@...en8.de, hpa@...or.com, ardb@...nel.org, mjg59@...f.ucam.org,
James.Bottomley@...senpartnership.com, luto@...capital.net,
nivedita@...m.mit.edu, kanth.ghatraju@...cle.com,
trenchboot-devel@...glegroups.com
Subject: Re: [PATCH v6 05/14] x86: Secure Launch main header file
On 5/5/23 12:25, Simon Horman wrote:
> On Thu, May 04, 2023 at 02:50:14PM +0000, Ross Philipson wrote:
>> Introduce the main Secure Launch header file used in the early SL stub
>> and the early setup code.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@...cle.com>
>> ---
>> include/linux/slaunch.h | 513 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 513 insertions(+)
>> create mode 100644 include/linux/slaunch.h
>>
>> diff --git a/include/linux/slaunch.h b/include/linux/slaunch.h
>
> ...
>
>> +/* TXTCR_STS status bits */
>> +#define TXT_SENTER_DONE_STS (1<<0)
>> +#define TXT_SEXIT_DONE_STS (1<<1)
>
> nit: Please consider using BIT()
Ack
>
> ...
>
>> +/*
>> + * External functions avalailable in mainline kernel.
>> + */
>> +extern void slaunch_setup_txt(void);
>> +extern u32 slaunch_get_flags(void);
>> +extern struct sl_ap_wake_info *slaunch_get_ap_wake_info(void);
>> +extern struct acpi_table_header *slaunch_get_dmar_table(struct acpi_table_header *dmar);
>> +extern void __noreturn slaunch_txt_reset(void __iomem *txt,
>> + const char *msg, u64 error);
>> +extern void slaunch_finalize(int do_sexit);
>
> I think that extern should be avoided.
> Perhaps these are in a header file that can be included?
Someone in an earlier review asked me to add the externs. The function
are not in another header, they are in a C module.
>
>> +
>> +#endif /* !__ASSEMBLY */
>> +
>> +#else
>> +
>> +#define slaunch_setup_txt() do { } while (0)
>> +#define slaunch_get_flags() 0
>> +#define slaunch_get_dmar_table(d) (d)
>> +#define slaunch_finalize(d) do { } while (0)
>
> I think it is usual to use static functions for this purpose.
> Usually they end up in header files as static inline functions.
Yea we can switch to using static functions.
Thanks
Ross
>
>> +
>> +#endif /* !IS_ENABLED(CONFIG_SECURE_LAUNCH) */
>> +
>> +#endif /* _LINUX_SLAUNCH_H */
Powered by blists - more mailing lists