linux-kernel - Re: [PATCH v1 9/9] drm/bridge: tc358768: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2023 20:10:18 +0200
From:   Robert Foss <rfoss@...nel.org>
To:     Francesco Dolcini <francesco@...cini.it>
Cc:     Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        tomi.valkeinen@...asonboard.com, dri-devel@...ts.freedesktop.org,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 9/9] drm/bridge: tc358768: remove unused variable

On Thu, Apr 27, 2023 at 4:34 PM Francesco Dolcini <francesco@...cini.it> wrote:
>
> From: Francesco Dolcini <francesco.dolcini@...adex.com>
>
> Remove the unused phy_delay_nsk variable, before it was wrongly used
> to compute some register value, the fixed computation is no longer using
> it and therefore can be removed.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
>  drivers/gpu/drm/bridge/tc358768.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index 947c7dca567a..d3af42a16e69 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -641,7 +641,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge)
>         u32 val, val2, lptxcnt, hact, data_type;
>         s32 raw_val;
>         const struct drm_display_mode *mode;
> -       u32 dsibclk_nsk, dsiclk_nsk, ui_nsk, phy_delay_nsk;
> +       u32 dsibclk_nsk, dsiclk_nsk, ui_nsk;
>         u32 dsiclk, dsibclk, video_start;
>         const u32 internal_delay = 40;
>         int ret, i;
> @@ -725,11 +725,9 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge)
>                                   dsibclk);
>         dsiclk_nsk = (u32)div_u64((u64)1000000000 * TC358768_PRECISION, dsiclk);
>         ui_nsk = dsiclk_nsk / 2;
> -       phy_delay_nsk = dsibclk_nsk + 2 * dsiclk_nsk;
>         dev_dbg(priv->dev, "dsiclk_nsk: %u\n", dsiclk_nsk);
>         dev_dbg(priv->dev, "ui_nsk: %u\n", ui_nsk);
>         dev_dbg(priv->dev, "dsibclk_nsk: %u\n", dsibclk_nsk);
> -       dev_dbg(priv->dev, "phy_delay_nsk: %u\n", phy_delay_nsk);
>
>         /* LP11 > 100us for D-PHY Rx Init */
>         val = tc358768_ns_to_cnt(100 * 1000, dsibclk_nsk) - 1;
> --
> 2.25.1
>

Reviewed-by: Robert Foss <rfoss@...nel.org>