linux-kernel - Re: [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 May 2023 16:45:29 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Neil Armstrong <neil.armstrong@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jianhua Lu <lujianhua000@...il.com>,
        Del Regno <angelogioacchino.delregno@...ainline.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define
 ports

On Tue, May 02, 2023 at 02:00:35PM +0200, Krzysztof Kozlowski wrote:
> The panel-common schema does not define what "ports" property is, so
> bring the definition to enforce the type.  Panels can be single- or
> dual-link, thus require only one port@0.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes since v1:
> 1. Rework to add ports to device schema, not to panel-common.
> https://lore.kernel.org/all/20230420160905.GA2952736-robh@kernel.org/
> ---
>  .../bindings/display/panel/novatek,nt35950.yaml           | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> index 377a05d48a02..c93cc1018b41 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> @@ -47,8 +47,13 @@ properties:
>    vddio-supply:
>      description: regulator that supplies the I/O voltage
>  
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports

Similarly needed on this one.

Perhaps what you want here is a dual-link panel schema?

> +
> +    required:
> +      - port@0
> +
>    backlight: true
> -  ports: true
>    reg: true
>  
>  required:
> @@ -59,6 +64,7 @@ required:
>    - avee-supply
>    - dvdd-supply
>    - vddio-supply
> +  - ports
>  
>  additionalProperties: false
>  
> -- 
> 2.34.1
>