linux-kernel - Re: [PATCH v2] ata: libata-scsi: Fix get identity data failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b4dee69-347f-4a53-d41d-5a0de96d9b2f@huawei.com>
Date:   Sat, 6 May 2023 17:49:00 +0800
From:   yangxingui <yangxingui@...wei.com>
To:     Jason Yan <yanaijie@...wei.com>,
        John Garry <john.g.garry@...cle.com>,
        Damien Le Moal <dlemoal@...nel.org>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <damien.lemoal@...nsource.wdc.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <prime.zeng@...ilicon.com>,
        <kangfenglong@...wei.com>
Subject: Re: [PATCH v2] ata: libata-scsi: Fix get identity data failed



On 2023/5/6 10:11, Jason Yan wrote:
> On 2023/5/5 17:14, yangxingui wrote:
>>
>>
>> On 2023/5/5 16:25, John Garry wrote:
>>> On 05/05/2023 09:17, Damien Le Moal wrote:
>>>>> --- a/drivers/ata/libata-scsi.c
>>>>> +++ b/drivers/ata/libata-scsi.c
>>>>> @@ -26,6 +26,7 @@
>>>>>   #include <scsi/scsi_device.h>
>>>>>   #include <scsi/scsi_tcq.h>
>>>>>   #include <scsi/scsi_transport.h>
>>>>> +#include <scsi/libsas.h>
>>>
>>> hmmm... is it really acceptable that libata is referencing libsas? I 
>>> didn't think that it would be. libsas uses libata, not the other way 
>>> around.
>> Yeah, I didn't expect that either. Is there any other way? If so, is 
>> patch v1 OK?
> 
> Hi Xingui,
> 
> Libsas should follow the standard way of libata to manage the ata 
> structures. Not the opposite way. So what you should do is to find a way 
> for libsas to behave as a normal ata driver. It's not good to make 
> libata aware of libsas or referencing libsas.
> 
> If you have detailed questions you can ask me internally(which will be 
> faster) or publicly through the maillist(which may have some delay).
> 
ok

Thanks,
Xingui
.
> Thanks,
> Jason
> .