linux-kernel - Re: [PATCH RESEND 1/2] pcmcia : make PCMCIA depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYo+NPtqjbUCrohE8yhyvc3vuqycP6RctY5rsiZXiiQWw@mail.gmail.com>
Date:   Sat, 6 May 2023 17:00:02 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        schnelle@...ux.ibm.com, linux-s390@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH RESEND 1/2] pcmcia : make PCMCIA depend on HAS_IOMEM

On Sat, May 6, 2023 at 1:16 PM Baoquan He <bhe@...hat.com> wrote:

> On s390 systems (aka mainframes), it has classic channel devices for
> networking and permanent storage that are currently even more common
> than PCI devices. Hence it could have a fully functional s390 kernel
> with CONFIG_PCI=n, then the relevant iomem mapping functions
> [including ioremap(), devm_ioremap(), etc.] are not available.
>
> Here let depend PCMCIA on HAS_IOMEM so that it won't be built to
> cause below compiling error if PCI is unset.
>
> -------------------------------------------------------
> ld: drivers/pcmcia/cistpl.o: in function `set_cis_map':
> cistpl.c:(.text+0x1202): undefined reference to `ioremap'
> ld: cistpl.c:(.text+0x13b0): undefined reference to `iounmap'
> ld: cistpl.c:(.text+0x14a6): undefined reference to `iounmap'
> ld: cistpl.c:(.text+0x1544): undefined reference to `ioremap'
> ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem':
> cistpl.c:(.text+0x3f14): undefined reference to `iounmap'
>
> Signed-off-by: Baoquan He <bhe@...hat.com>
> Reviewed-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij