linux-kernel - Re: [PATCH v2 2/2] misc: fastrpc: use coherent pool for untranslated Compute Banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5b3f7b4-3b08-d5cf-b1b9-795e9491166f@connolly.tech>
Date:   Sat, 06 May 2023 17:30:31 +0000
From:   Caleb Connolly <caleb@...nolly.tech>
To:     Dylan Van Assche <me@...anvanassche.be>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Amol Maheshwari <amahesh@....qualcomm.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] misc: fastrpc: use coherent pool for untranslated Compute Banks



On 27/03/2023 19:42, Dylan Van Assche wrote:
> Use fastrpc_remote_heap_alloc to allocate from the FastRPC device
> instead of the Compute Bank when the session ID is 0. This ensures
> that the allocation is inside the coherent DMA pool which is already
> accessible to the DSP. This is necessary to support FastRPC devices
> which do not have dedicated Compute Banks such as the SLPI on the SDM845.
> The latter uses an allocated CMA region instead of FastRPC Compute Banks.
>
> Signed-off-by: Dylan Van Assche <me@...anvanassche.be>

Reviewed-by: Caleb Connolly <caleb.connolly@...aro.org>
> ---
>  drivers/misc/fastrpc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index caf2ae556956..b7ddf6b90022 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -939,7 +939,10 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_invoke_ctx *ctx)
>
>  	ctx->msg_sz = pkt_size;
>
> -	err = fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> +	if (ctx->fl->sctx->sid)
> +		err = fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> +	else
> +		err = fastrpc_remote_heap_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
>  	if (err)
>  		return err;
>
> --
> 2.39.2
>

--
Kind Regards,
Caleb