linux-kernel - Re: [PATCH v2] scsi: qedf: Fix NULL dereference in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1fs892i6h.fsf@ca-mkp.ca.oracle.com>
Date:   Sat, 06 May 2023 18:45:18 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jinhong Zhu <jinhongzhu@...t.edu.cn>
Cc:     Saurav Kashyap <skashyap@...vell.com>,
        Javed Hasan <jhasan@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Manish Rangankar <manish.rangankar@...ium.com>,
        Arun Easi <arun.easi@...ium.com>,
        Nilesh Javali <nilesh.javali@...ium.com>,
        Dan Carpenter <error27@...il.com>,
        Saurav Kashyap <saurav.kashyap@...ium.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: qedf: Fix NULL dereference in error handling


Jinhong,

> Smatch reported:
>
> drivers/scsi/qedf/qedf_main.c:3056 qedf_alloc_global_queues()
> warn: missing unwind goto?
>
> At this point in the function, nothing has been allocated so we can
> return directly. In particular the "qedf->global_queues" have not been
> allocated so calling qedf_free_global_queues() will lead to a NULL
> dereference when we check if (!gl[i]) and "gl" is NULL.

Applied to 6.5/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering