linux-kernel - RE: [PATCH] Drivers: hv: vmbus: Call hv_synic_free() if hv_synic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR21MB13353DEBB073AB77C933C885BF739@SA1PR21MB1335.namprd21.prod.outlook.com>
Date:   Sat, 6 May 2023 02:38:04 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...nel.org" <stable@...nel.org>
Subject: RE: [PATCH] Drivers: hv: vmbus: Call hv_synic_free() if
 hv_synic_alloc() fails

> From: Michael Kelley (LINUX) <mikelley@...rosoft.com>
> Sent: Friday, May 5, 2023 5:30 PM
> ...
> From: Dexuan Cui <decui@...rosoft.com> Sent: Thursday, May 4, 2023 3:42
> PM
> >
> > Commit 572086325ce9 ("Drivers: hv: vmbus: Cleanup synic memory free
> > path")
> > says "Any memory allocations that succeeded will be freed when the caller
> > cleans up by calling hv_synic_free()", but if the get_zeroed_page() in
> > hv_synic_alloc() fails, currently hv_synic_free() is not really called
> > in vmbus_bus_init(), consequently there will be a memory lead, e.g.
> 
> s/lead/leak/

Sorry for the typo. Wei, can you please help fix this?
 
> > hv_context.hv_numa_map is not freed in the error path. Fix this by
> > updating the goto lables.
> 
> s/lables/labels/
Ditto.
 
> The statement in commit 572086325ce9 was true at the time of that
> commit.  But I broke things in commit 4df4cb9e99f8.  Should add a
> "Fixes:" tag for 4df4cb9e99f8.

I suppose Wei can help add the line:
Fixes: 4df4cb9e99f8 ("x86/hyperv: Initialize clockevents earlier in CPU onlining")

> Nits notwithstanding,
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>

Thanks!