linux-kernel - Re: [PATCH] riscv: mm: use bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 May 2023 21:09:57 +0530
From:   Anup Patel <anup@...infault.org>
To:     ye.xingchen@....com.cn
Cc:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, guoren@...nel.org,
        sergey.matyukevich@...tacore.com, dylan@...estech.com,
        ajones@...tanamicro.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: mm: use bitmap_zero() API

On Sat, May 6, 2023 at 2:42 PM <ye.xingchen@....com.cn> wrote:
>
> From: Ye Xingchen <ye.xingchen@....com.cn>
>
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().
>
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Looks good to me.

Reviewed-by: Anup Patel <anup@...infault.org>

Regards,
Anup

> ---
>  arch/riscv/mm/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
> index 12e22e7330e7..217fd4de6134 100644
> --- a/arch/riscv/mm/context.c
> +++ b/arch/riscv/mm/context.c
> @@ -67,7 +67,7 @@ static void __flush_context(void)
>         lockdep_assert_held(&context_lock);
>
>         /* Update the list of reserved ASIDs and the ASID bitmap. */
> -       bitmap_clear(context_asid_map, 0, num_asids);
> +       bitmap_zero(context_asid_map, num_asids);
>
>         /* Mark already active ASIDs as used */
>         for_each_possible_cpu(i) {
> --
> 2.25.1