linux-kernel - RE: [PATCH] drm/exynos: g2d: staticize stubs in header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <004001d98101$fa5ed690$ef1c83b0$@samsung.com>
Date:   Sun, 7 May 2023 22:05:45 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'Inki Dae'" <inki.dae@...sung.com>,
        "'Seung-Woo Kim'" <sw0312.kim@...sung.com>,
        "'Kyungmin Park'" <kyungmin.park@...sung.com>,
        "'David Airlie'" <airlied@...il.com>,
        "'Daniel Vetter'" <daniel@...ll.ch>,
        "'Marek Szyprowski'" <m.szyprowski@...sung.com>,
        <dri-devel@...ts.freedesktop.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/exynos: g2d: staticize stubs in header

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Sunday, May 7, 2023 8:18 PM
> To: Inki Dae <inki.dae@...sung.com>; Seung-Woo Kim
> <sw0312.kim@...sung.com>; Kyungmin Park
> <kyungmin.park@...sung.com>; David Airlie <airlied@...il.com>; Daniel
> Vetter <daniel@...ll.ch>; Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org>; Alim Akhtar <alim.akhtar@...sung.com>;
> Marek Szyprowski <m.szyprowski@...sung.com>; dri-
> devel@...ts.freedesktop.org; linux-arm-kernel@...ts.infradead.org; linux-
> samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] drm/exynos: g2d: staticize stubs in header
> 
> Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> inline:
> 
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous
> prototype for ‘g2d_open’ [-Wmissing-prototypes]
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous
> prototype for ‘g2d_close’ [-Wmissing-prototypes]
> 
> Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>


>  drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> index 74ea3c26dead..1a5ae781b56c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct
> drm_device *dev, void *data,
>  	return -ENODEV;
>  }
> 
> -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
>  {
>  	return 0;
>  }
> 
> -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
>  { }
>  #endif
> --
> 2.34.1