linux-kernel - Re: [PATCH] phy: hisilicon: Adopt phy-hisi-inno-usb2 to Hi3798MV100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202305080013.kOt0Vzuc-lkp@intel.com>
Date:   Mon, 8 May 2023 00:57:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Yang <mmyangfl@...il.com>, linux-phy@...ts.infradead.org
Cc:     oe-kbuild-all@...ts.linux.dev, David Yang <mmyangfl@...il.com>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: hisilicon: Adopt phy-hisi-inno-usb2 to Hi3798MV100

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.3 next-20230505]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Yang/phy-hisilicon-Adopt-phy-hisi-inno-usb2-to-Hi3798MV100/20230507-234747
base:   linus/master
patch link:    https://lore.kernel.org/r/20230507154615.793942-1-mmyangfl%40gmail.com
patch subject: [PATCH] phy: hisilicon: Adopt phy-hisi-inno-usb2 to Hi3798MV100
config: arm64-buildonly-randconfig-r001-20230507 (https://download.01.org/0day-ci/archive/20230508/202305080013.kOt0Vzuc-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/fe830916b152e401719061112b0b4fb140502d08
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review David-Yang/phy-hisilicon-Adopt-phy-hisi-inno-usb2-to-Hi3798MV100/20230507-234747
        git checkout fe830916b152e401719061112b0b4fb140502d08
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/phy/hisilicon/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305080013.kOt0Vzuc-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/phy/hisilicon/phy-hisi-inno-usb2.c: In function 'hisi_inno_phy_probe':
>> drivers/phy/hisilicon/phy-hisi-inno-usb2.c:165:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     165 |         priv->type = (unsigned int) of_device_get_match_data(dev);
         |                      ^


vim +165 drivers/phy/hisilicon/phy-hisi-inno-usb2.c

   136	
   137	static int hisi_inno_phy_probe(struct platform_device *pdev)
   138	{
   139		struct device *dev = &pdev->dev;
   140		struct device_node *np = dev->of_node;
   141		struct hisi_inno_phy_priv *priv;
   142		struct phy_provider *provider;
   143		struct device_node *child;
   144		int i = 0;
   145		int ret;
   146	
   147		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
   148		if (!priv)
   149			return -ENOMEM;
   150	
   151		priv->mmio = devm_platform_ioremap_resource(pdev, 0);
   152		if (IS_ERR(priv->mmio)) {
   153			ret = PTR_ERR(priv->mmio);
   154			return ret;
   155		}
   156	
   157		priv->ref_clk = devm_clk_get(dev, NULL);
   158		if (IS_ERR(priv->ref_clk))
   159			return PTR_ERR(priv->ref_clk);
   160	
   161		priv->por_rst = devm_reset_control_get_exclusive(dev, NULL);
   162		if (IS_ERR(priv->por_rst))
   163			return PTR_ERR(priv->por_rst);
   164	
 > 165		priv->type = (unsigned int) of_device_get_match_data(dev);
   166	
   167		for_each_child_of_node(np, child) {
   168			struct reset_control *rst;
   169			struct phy *phy;
   170	
   171			rst = of_reset_control_get_exclusive(child, NULL);
   172			if (IS_ERR(rst)) {
   173				of_node_put(child);
   174				return PTR_ERR(rst);
   175			}
   176	
   177			priv->ports[i].utmi_rst = rst;
   178			priv->ports[i].priv = priv;
   179	
   180			phy = devm_phy_create(dev, child, &hisi_inno_phy_ops);
   181			if (IS_ERR(phy)) {
   182				of_node_put(child);
   183				return PTR_ERR(phy);
   184			}
   185	
   186			phy_set_bus_width(phy, 8);
   187			phy_set_drvdata(phy, &priv->ports[i]);
   188			i++;
   189	
   190			if (i > INNO_PHY_PORT_NUM) {
   191				dev_warn(dev, "Support %d ports in maximum\n", i);
   192				of_node_put(child);
   193				break;
   194			}
   195		}
   196	
   197		provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
   198		return PTR_ERR_OR_ZERO(provider);
   199	}
   200	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests