linux-kernel - RE: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR21MB31168035C903BD666253BF70CA709@PH7PR21MB3116.namprd21.prod.outlook.com>
Date:   Sun, 7 May 2023 21:39:27 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Leon Romanovsky <leon@...nel.org>, Long Li <longli@...rosoft.com>
CC:     Jason Gunthorpe <jgg@...pe.ca>,
        Ajay Sharma <sharmaajay@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req to
 enable RX coalescing



> -----Original Message-----
> From: Leon Romanovsky <leon@...nel.org>
> Sent: Sunday, May 7, 2023 4:11 AM
> To: Long Li <longli@...rosoft.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>; Ajay Sharma
> <sharmaajay@...rosoft.com>; Dexuan Cui <decui@...rosoft.com>; KY
> Srinivasan <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>;
> Wei Liu <wei.liu@...nel.org>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; linux-rdma@...r.kernel.org; linux-
> hyperv@...r.kernel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req to
> enable RX coalescing
> 
> On Fri, May 05, 2023 at 11:51:48AM -0700, longli@...uxonhyperv.com
> wrote:
> > From: Long Li <longli@...rosoft.com>
> >
> > With RX coalescing, one CQE entry can be used to indicate multiple packets
> > on the receive queue. This saves processing time and PCI bandwidth over
> > the CQ.
> >
> > Signed-off-by: Long Li <longli@...rosoft.com>
> > ---
> >  drivers/infiniband/hw/mana/qp.c |  5 ++++-
> >  include/net/mana/mana.h         | 17 +++++++++++++++++
> >  2 files changed, 21 insertions(+), 1 deletion(-)
> 
> Why didn't you change mana_cfg_vport_steering() too?

The mana_cfg_vport_steering() is for mana_en (Enthernet) driver, not the
mana_ib driver.

The changes for mana_en will be done in a separate patch together with
changes for mana_en RX code patch to support multiple packets / CQE.

Thanks,
- Haiyang