linux-kernel - Re: [PATCH] scripts: rust_is_available: check for empty libclang version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44dc8206-a42b-047b-bd2d-62b54fbe8ee8@gmail.com>
Date:   Sun, 7 May 2023 20:15:54 -0300
From:   Martin Rodriguez Reboredo <yakoyoku@...il.com>
To:     Matthew Leach <dev@...tleach.net>, Miguel Ojeda <ojeda@...nel.org>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>
Cc:     rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: rust_is_available: check for empty libclang
 version

On 5/7/23 05:41, Matthew Leach wrote:
> If bindgen can't find libclang, then bindgen will panic with the
> following error:
> 
> thread 'main' panicked at 'Unable to find libclang: "couldn't find any
> valid shared libraries matching: ['libclang.so', 'libclang-*.so',
> 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment
> variable to a path where one of these files can be found.
> 
> This is outputted to stderr, leaving stdout empty. The empty string is
> then passed to get_canonical_version and the following is show to the
> user:
> 
> $ make LLVM=1 rustavailable
> ./scripts/rust_is_available.sh: line 21: 100000 *  + 100 *  + : syntax error: operand expected (error token is "+ ")
> make: *** [Makefile:1825: rustavailable] Error 1
> 
> Note: bindgen's bad exit code isn't caught by 'set -e' since it is ran
> in a subshell.
> 
> Fix this by prnting out a more helpful error message if the output of
> bindgen is empty.
> 
> Signed-off-by: Matthew Leach <dev@...tleach.net>
> ---
> [...]

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>