linux-kernel - Re: [PATCH 2/2] dt-bindings: mmc: brcm,kona-sdhci: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230508-earwig-prance-a2f25f23551d@spud>
Date:   Mon, 8 May 2023 20:56:07 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Stanislav Jakubek <stano.jakubek@...il.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mmc: brcm,kona-sdhci: convert to YAML

On Mon, May 08, 2023 at 02:46:03PM +0200, Stanislav Jakubek wrote:
> Convert Broadcom Kona family SDHCI controller bindings to DT schema.
> 
> Changes during conversion:
>   - also mark reg and interrupts as required
>   - drop deprecated compatible (it's been deprecated for ~10 years)
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> ---
>  .../bindings/mmc/brcm,kona-sdhci.txt          | 21 --------
>  .../bindings/mmc/brcm,kona-sdhci.yaml         | 48 +++++++++++++++++++
>  2 files changed, 48 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.txt
>  create mode 100644 Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.txt b/Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.txt
> deleted file mode 100644
> index 7f5dd83f5bd9..000000000000
> --- a/Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -Broadcom BCM281xx SDHCI
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties present in the bcm281xx SDHCI
> -
> -Required properties:
> -- compatible : Should be "brcm,kona-sdhci"
> -- DEPRECATED: compatible : Should be "bcm,kona-sdhci"
> -- clocks: phandle + clock specifier pair of the external clock
> -
> -Refer to clocks/clock-bindings.txt for generic clock consumer properties.
> -
> -Example:
> -
> -sdio2: sdio@...a0000 {
> -	compatible = "brcm,kona-sdhci";
> -	reg = <0x3f1a0000 0x10000>;
> -	clocks = <&sdio3_clk>;
> -	interrupts = <0x0 74 0x4>;
> -};
> -
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.yaml b/Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.yaml
> new file mode 100644
> index 000000000000..87711edf9b39
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/brcm,kona-sdhci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom Kona family SDHCI controller
> +
> +maintainers:
> +  - Florian Fainelli <f.fainelli@...il.com>
> +
> +allOf:
> +  - $ref: sdhci-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: brcm,kona-sdhci
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include "dt-bindings/clock/bcm281xx.h"
> +
> +    mmc@...a0000 {
> +        compatible = "brcm,kona-sdhci";
> +        reg = <0x3f1a0000 0x10000>;
> +        clocks = <&master_ccu BCM281XX_MASTER_CCU_SDIO3>;
> +        interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> +    };
> +...
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)