linux-kernel - Re: [PATCH v4 5/8] power: supply: rt5033_charger: Add RT5033 charger device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c99e915-b067-367d-bdbe-095b7f244aa4@rocketmail.com>
Date:   Mon, 8 May 2023 22:27:34 +0200
From:   Jakob Hauser <jahau@...ketmail.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Beomho Seo <beomho.seo@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Raymond Hackley <raymondhackley@...tonmail.com>,
        Pavel Machek <pavel@....cz>, Axel Lin <axel.lin@...ics.com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Henrik Grimler <henrik@...mler.se>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v4 5/8] power: supply: rt5033_charger: Add RT5033 charger
 device driver

Hi Sebastian,

On 08.05.23 08:50, Sebastian Reichel wrote:
> Hi,
> 
> On Sat, May 06, 2023 at 05:54:32PM +0200, Jakob Hauser wrote:
>> This patch adds device driver of Richtek RT5033 PMIC. The driver supports
>> switching charger. rt5033 charger provides three charging modes. The charging
>> modes are pre-charge mode, fast charge mode and constant voltage mode. They
>> vary in charge rate, the charge parameters can be controlled by i2c interface.
>>
>> Cc: Beomho Seo <beomho.seo@...sung.com>
>> Cc: Chanwoo Choi <cw00.choi@...sung.com>
>> Tested-by: Raymond Hackley <raymondhackley@...tonmail.com>
>> Signed-off-by: Jakob Hauser <jahau@...ketmail.com>
>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>> ---
> 
> Driver looks mostly good. I still found a couple of small things
> though. Please find them inline.

...

The change requests look reasonable. Thanks for additional hints. I'll 
implement them in v5.

Kind regards,
Jakob