linux-kernel - [PATCH] Revert "drm/msm/dp: Remove INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebbcd56ac883d3c3d3024d368fab63d26e02637a@lausen.nl>
Date:   Mon, 08 May 2023 01:06:13 +0000
From:   "Leonard Lausen" <leonard@...sen.nl>
To:     regressions@...ts.linux.dev,
        "Bjorn Andersson" <quic_bjorande@...cinc.com>,
        "Dmitry Baryshkov" <dmitry.baryshkov@...aro.org>,
        "Rob Clark" <robdclark@...il.com>,
        "Abhinav Kumar" <quic_abhinavk@...cinc.com>,
        "Stephen Boyd" <swboyd@...omium.org>,
        "Kuogee Hsieh" <quic_khsieh@...cinc.com>,
        "Johan Hovold" <johan+linaro@...nel.org>,
        "Sankeerth Billakanti" <quic_sbillaka@...cinc.com>
Cc:     "Sean Paul" <sean@...rly.run>, "David Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, "Nikita Travkin" <nikita@...n.ru>
Subject: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97.

Removing the delay of 100 units broke hot plug detection for USB-C displays on
qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares
dp_hot_plug_det in the dts. Other sc7180 based devices like aspire1 were not
affected by the regression, as they do not rely on mdss and dp_hot_plug_det for
hot plug detection.

Signed-off-by: Leonard Lausen <leonard@...sen.nl>
Tested-by: Leonard Lausen <leonard@...sen.nl> # Trogdor (sc7180)
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index bde1a7ce442f..db9783ffd5cf 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1506,7 +1506,7 @@ void msm_dp_irq_postinstall(struct msm_dp *dp_display)
        dp = container_of(dp_display, struct dp_display_private, dp_display);
 
        if (!dp_display->is_edp)
-               dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 0);
+               dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
 }
 
 bool msm_dp_wide_bus_available(const struct msm_dp *dp_display)
-- 
2.30.2