[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <df471efa-9ec5-f323-3892-2505ba782512@linaro.org>
Date: Mon, 8 May 2023 08:20:59 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Abel Vesa <abel.vesa@...aro.org>,
Ulf Hansson <ulf.hansson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Manivannan Sadhasivam <mani@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Avri Altman <avri.altman@....com>,
Bart Van Assche <bvanassche@....org>,
Adrian Hunter <adrian.hunter@...el.com>,
"James E . J . Bottomley" <jejb@...ux.ibm.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S . Miller" <davem@...emloft.net>,
Eric Biggers <ebiggers@...nel.org>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
linux-scsi@...r.kernel.org
Subject: Re: [PATCH v7 1/3] dt-bindings: ufs: qcom: Add ICE phandle
On 05/05/2023 20:47, Krzysztof Kozlowski wrote:
> On 08/04/2023 23:40, Abel Vesa wrote:
>> Starting with SM8550, the ICE will have its own devicetree node
>> so add the qcom,ice property to reference it.
>>
>> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
>> ---
>>
>> The v6 is here:
>> https://lore.kernel.org/all/20230407105029.2274111-3-abel.vesa@linaro.org/
>>
>> Changes since v6:
>> * Dropped the minItems for both the qcom,ice and the reg in the
>> qcom,ice compatile subschema, like Krzysztof suggested
>>
>> Changes since v5:
>> * dropped the sm8550 specific subschema and replaced it with one that
>> mutually excludes the qcom,ice vs both the ICE specific reg range
>> and the ICE clock
>>
>> Changes since v4:
>> * Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce
>> it while making sure none of the other platforms are allowed to use it
>>
>> Changes since v3:
>> * dropped the "and drop core clock" part from subject line
>>
>> Changes since v2:
>> * dropped all changes except the qcom,ice property
>>
>>
>> .../devicetree/bindings/ufs/qcom,ufs.yaml | 24 +++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>
> I see dt_binding_check errors after applying this patch. Are you sure
> this was tested?
False alarm, it was other patch in my tree.
This one is good.
Best regards,
Krzysztof
Powered by blists - more mailing lists