linux-kernel - Re: [PATCH] remoteproc: qcom_q6v5_pas: staticize adsp_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4dd89422-f40a-b772-2b9c-f6442b01d2b0@linaro.org>
Date:   Mon, 8 May 2023 09:43:47 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: qcom_q6v5_pas: staticize adsp_segment_dump()



On 7.05.2023 16:48, Krzysztof Kozlowski wrote:
> adsp_segment_dump() is not used outside of this unit, so add missing
> static to fix:
> 
>   drivers/remoteproc/qcom_q6v5_pas.c:108:6: warning: no previous prototype for ‘adsp_segment_dump’ [-Wmissing-prototypes]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

(should we add a fixes tag for this one? I'm unsure but wouldn't mind
either way)

Konrad
>  drivers/remoteproc/qcom_q6v5_pas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..f77d11c91a75 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,7 +105,7 @@ struct qcom_adsp {
>  	struct qcom_scm_pas_metadata dtb_pas_metadata;
>  };
>  
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> +static void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
>  		       void *dest, size_t offset, size_t size)
>  {
>  	struct qcom_adsp *adsp = rproc->priv;